[U-Boot] [PATCH 30/60] ARM: tegra: remove pmu.h

Simon Glass sjg at chromium.org
Fri Apr 22 20:32:39 CEST 2016


Hi Stephen,

On 19 April 2016 at 14:59, Stephen Warren <swarren at wwwdotorg.org> wrote:
> From: Stephen Warren <swarren at nvidia.com>
>
> This header is duplicated many times, and does nothing but prototype a
> single function that's used solely by mach-tegra code. Move the proto-
> type of mach-tegra/cpu.h. That's not an awesome location for it, but
> other similar functions like pmic_enable_cpu_vdd() are already there.
>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  arch/arm/include/asm/arch-tegra114/pmu.h | 13 -------------
>  arch/arm/include/asm/arch-tegra124/pmu.h | 14 --------------
>  arch/arm/include/asm/arch-tegra20/pmu.h  | 14 --------------
>  arch/arm/include/asm/arch-tegra210/pmu.h | 14 --------------
>  arch/arm/include/asm/arch-tegra30/pmu.h  | 13 -------------
>  arch/arm/mach-tegra/board2.c             |  1 -
>  arch/arm/mach-tegra/cpu.h                |  2 ++
>  arch/arm/mach-tegra/emc.c                |  1 -
>  8 files changed, 2 insertions(+), 70 deletions(-)
>  delete mode 100644 arch/arm/include/asm/arch-tegra114/pmu.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra124/pmu.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra20/pmu.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra210/pmu.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra30/pmu.h

Reviewed-by: Simon Glass <sjg at chromium.org>

I wonder if it would be better to retain the header name and move
pmic_enable_cpu_vdd()?

- Simon


More information about the U-Boot mailing list