[U-Boot] [PATCH] omap3_igep00x0.h: Drop SPL MMC support on BOOT_NAND

[Enric Balletbo Serra]

Hi Tom,

2016-04-25 17:16 GMT+02:00 Tom Rini <trini at konsulko.com>:
> On Mon, Apr 25, 2016 at 05:09:50PM +0200, Enric Balletbo Serra wrote:
>> Hi Tom,
>>
>> 2016-04-25 16:44 GMT+02:00 Tom Rini <trini at konsulko.com>:
>> > In the case of booting from NAND on these boards, remove MMC support
>> > from SPL so that we can continue to fit into the safest partitioning of
>> > the available SRAM.
>> >
>> > Reported-by: Heiko Schocher <hs at denx.de>
>> > Cc: Enric Balletbo i Serra <eballetbo at gmail.com>
>> > Signed-off-by: Tom Rini <trini at konsulko.com>
>> > ---
>> >  include/configs/omap3_igep00x0.h | 10 ++++++++++
>> >  1 file changed, 10 insertions(+)
>> >
>> > diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h
>> > index 5e33845..3cdee02 100644
>> > --- a/include/configs/omap3_igep00x0.h
>> > +++ b/include/configs/omap3_igep00x0.h
>> > @@ -20,6 +20,16 @@
>> >  #include <asm/mach-types.h>
>> >
>> >  /*
>> > + * Remove non-NAND boot modes.
>> > + */
>> > +#ifdef CONFIG_BOOT_NAND
>> > +#undef CONFIG_SPL_LIBDISK_SUPPORT
>> > +#undef CONFIG_SPL_MMC_SUPPORT
>> > +#undef CONFIG_SPL_FAT_SUPPORT
>> > +#undef CONFIG_SPL_EXT_SUPPORT
>> > +#endif
>> > +
>>
>> Hmm, this will break boot from a sdcard, on IGEP the same SPL binary
>> is used to boot from flash or sdcard. The reason why we have two
>> defconfigs is to select if the board has a ONENAND
>> (igep00xx_defconfig) or a NAND (igep00xx_nand_defconfig) but both must
>> have support for MMC.
>
> Ah, OK.  So the next thing to do is see about changing
> CONFIG_SPL_MAX_SIZE.  Or if you don't use SPL EXT2/4 support already,
> perhaps drop that?
>

We're really close to the limit, current size with my compiler is
57312. I saw that SPL_MAX_SIZE is set 54K in
include/configs/ti_omap3_common.h, maybe we can grow a bit more the
max SPL size?

I will take a look what I'm not using but indeed EXT2/4 is not used at
the moment in SPL.

Regards,
- Enric

> --
> Tom