[U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2

Beniamino Galvani b.galvani at gmail.com
Wed Apr 27 12:58:32 CEST 2016


On Mon, Apr 25, 2016 at 04:53:09PM -0400, Tom Rini wrote:
> > +#if !defined(CONFIG_IDENT_STRING)
> > +# define CONFIG_IDENT_STRING		" odroid-c2"
> > +#endif
> 
> Would this ever already be set?

No, it shouldn't.

> > +/* Serial setup */
> > +#define CONFIG_CONS_INDEX		0
> > +#define CONFIG_BAUDRATE			115200
> > +#define CONFIG_SYS_BAUDRATE_TABLE \
> > +	{ 4800, 9600, 19200, 38400, 57600, 115200 }
> 
> And I assume you could live with the default table really.

Right.

I will fix both and resubmit, thanks!

Beniamino


More information about the U-Boot mailing list