[U-Boot] [RFC PATCH] gpio: add Tegra186 GPIO driver

[Simon Glass]

Hi Stephen,

On 20 April 2016 at 17:28, Stephen Warren <swarren at wwwdotorg.org> wrote:
> From: Stephen Warren <swarren at nvidia.com>
>
> Tegra186's GPIO controller register layout is significantly different from
> previous chips, so add a new driver for it. In fact, there are two
> different GPIO controllers in Tegra186 that share a similar register
> layout, but very different port mapping. This driver covers both.
>
> The DT binding is already present in the Linux kernel (FIXME: Validate
> this when submitting).
> FIXME: Add DT binding file to this commit.
>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  arch/arm/mach-tegra/Kconfig              |   3 +
>  drivers/gpio/Kconfig                     |   9 +
>  drivers/gpio/Makefile                    |   1 +
>  drivers/gpio/tegra186_gpio.c             | 271 +++++++++++++++++++++++++++++++
>  drivers/gpio/tegra186_gpio_priv.h        |  61 +++++++
>  include/dt-bindings/gpio/tegra186-gpio.h |  56 +++++++
>  6 files changed, 401 insertions(+)
>  create mode 100644 drivers/gpio/tegra186_gpio.c
>  create mode 100644 drivers/gpio/tegra186_gpio_priv.h
>  create mode 100644 include/dt-bindings/gpio/tegra186-gpio.h

Reviewed-by: Simon Glass <sjg at chromium.org>

My only comment is that tegra186_gpio_get_value() should return 0 or 1.

I haven't seen the device tree, but presumably it is just a single node?

- Simon