[U-Boot] [PATCH] i2c: designware_i2c: Optionally check enable status register

Heiko Schocher hs at denx.de
Thu Apr 28 08:22:36 CEST 2016


Hello Stefan,

Am 28.04.2016 um 08:10 schrieb Stefan Roese:
> Hi Heiko,
>
> On 28.04.2016 08:06, Heiko Schocher wrote:
>> Am 27.04.2016 um 09:02 schrieb Stefan Roese:
>>> Some platforms don't implement the enable status register at offset 0x9c.
>>> The SPEAr600 platform is one of them. The recently added check to this
>>> status register can't be performend on these platforms.
>>>
>>> This patch introduces a new config option that can be enabled on such
>>> platforms not supporting this register.
>>>
>>> Signed-off-by: Stefan Roese <sr at denx.de>
>>> Cc: Heiko Schocher <hs at denx.de>
>>> ---
>>>   drivers/i2c/designware_i2c.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>
>> No objections, but I miss an entry in drivers/i2c/Kconfig or at least an
>> entry in README. Please add this, thanks!
>
> Yes, I am aware that this is not available via Kconfig. I hesitate
> to add it to the README, as this is a bit outdated. And we should
> move to Kconfig anyways.

Yes!

> I'll work on a patch to move this driver and this config option to
> Kconfig instead.

Ok, thanks for the info, so I am fine with this patch:

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list