[U-Boot] [RFC PATCH] gpio: add Tegra186 GPIO driver

[Simon Glass]

Hi Stephen,

On 27 April 2016 at 10:01, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 04/27/2016 09:12 AM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 20 April 2016 at 17:28, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>>
>>> From: Stephen Warren <swarren at nvidia.com>
>>>
>>> Tegra186's GPIO controller register layout is significantly different
>>> from
>>> previous chips, so add a new driver for it. In fact, there are two
>>> different GPIO controllers in Tegra186 that share a similar register
>>> layout, but very different port mapping. This driver covers both.
>>>
>>> The DT binding is already present in the Linux kernel (FIXME: Validate
>>> this when submitting).
>>> FIXME: Add DT binding file to this commit.
>>>
>>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>>> ---
>>>   arch/arm/mach-tegra/Kconfig              |   3 +
>>>   drivers/gpio/Kconfig                     |   9 +
>>>   drivers/gpio/Makefile                    |   1 +
>>>   drivers/gpio/tegra186_gpio.c             | 271
>>> +++++++++++++++++++++++++++++++
>>>   drivers/gpio/tegra186_gpio_priv.h        |  61 +++++++
>>>   include/dt-bindings/gpio/tegra186-gpio.h |  56 +++++++
>>>   6 files changed, 401 insertions(+)
>>>   create mode 100644 drivers/gpio/tegra186_gpio.c
>>>   create mode 100644 drivers/gpio/tegra186_gpio_priv.h
>>>   create mode 100644 include/dt-bindings/gpio/tegra186-gpio.h
>>
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> My only comment is that tegra186_gpio_get_value() should return 0 or 1.
>
>
> Thanks, fixed locally. As you may have noticed, I actually sent that patch
> out accidentally when I meant to send something else. Still, the remaining
> work is in the binding approval and addition to this patch, not the code you
> reviewed which I don't expect will change:-)
>
>> I haven't seen the device tree, but presumably it is just a single node?
>
>
> There's one DT node per top-level controller instance. The patch I sent for
> that is at:
>
> https://patchwork.ozlabs.org/patch/609516/
> [V2] ARM: tegra: add DT binding for Tegra186 GPIO controllers
>

Thanks, looks good.

Regards,
Simon