[U-Boot] spl_mmc: allow to load raw image

[Adam Ford]

Does anyone with an OMAP3 board have any issues with this patch?  I
will admit I haven't stayed on top of stuff due to moving, and other
issues at home, but I pulled down the master to reviews some on
related stuff, and found that master doesn't boot.  I used git bisect
this morning and it narrowed down a problem with booting to this
patch.

With the patch, I get:

U-Boot SPL 2016.03-00378-g4976f48 (Apr 29 2016 - 09:25:27)
Trying to boot from MMC
(hang)


Without the patch, I get:

U-Boot SPL 2016.03-00377-g73b5b27 (Apr 29 2016 - 09:26:30)
Trying to boot from MMC
bad magic
bad magic
reading args
spl_load_image_fat_os: error reading image args, err - -1
reading u-boot.img
reading u-boot.img

(U-boot loads)

On Thu, Mar 17, 2016 at 11:12 AM, Tom Rini <trini at konsulko.com> wrote:
> On Fri, Mar 18, 2016 at 01:07:47AM +0900, Masahiro Yamada wrote:
>> Hi Tom,
>>
>> 2016-03-17 11:04 GMT+09:00 Tom Rini <trini at konsulko.com>:
>> > On Mon, Feb 29, 2016 at 08:31:57PM +0900, Masahiro Yamada wrote:
>> >
>> >> The function spl_parse_image_header() falls back to a raw image
>> >> if the U-Boot header is missing and CONFIG_SPL_PANIC_ON_RAW_IMAGE
>> >> is undefined.  While, the bad magic checking here makes the
>> >> spl_parse_image_header() unreachable in case of the missing header.
>> >>
>> >> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>> >> Reviewed-by: Tom Rini <trini at konsulko.com>
>> >
>> > Applied to u-boot/master, thanks!
>>
>> I guess this is false.
>>
>> This is v1 that you said does not work as is.
>
> Yup, oops, forgot to delete it from my local bundle.
>
> --
> Tom
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>