[U-Boot] in cmd/fdt.c, why is CONFIG_OF_CONTROL described as "temporary #ifdef"?

Robert P. J. Day rpjday at crashcourse.ca
Sat Apr 30 08:12:49 CEST 2016


  puzzled by this in cmd/fdt.c:

    /* Temporary #ifdef - some archs don't have fdt_blob yet */
    #ifdef CONFIG_OF_CONTROL
                if (argc && !strcmp(*argv, "-c")) {
                        control = 1;
                        argc--;
                        argv++;
                }
    #endif

why is that #ifdef described as temporary? first, it seems that all
arch-specific global_data.h files include <asm-generic/global_data.h>,
where struct global_data contains an unconditional:

    const void *fdt_blob;   /* Our device tree, NULL if none */

so all arches at least have access to that struct member, even if they
don't currently support OF_CONTROL.

  more to the point, even if all arches *did* (or do?) support that
option, would that #ifdef suddenly disappear? isn't CONFIG_OF_CONTROL
a perfectly reasonable option for a developer to *choose* whether they
want or not?

  what's "temporary" about that #ifdef?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




More information about the U-Boot mailing list