[U-Boot] [RFC PATCH] i2c: i2c-uclass-compat: avoid any BSS usage

Simon Glass sjg at chromium.org
Mon Aug 1 03:03:33 CEST 2016


On 28 July 2016 at 21:37, Heiko Schocher <hs at denx.de> wrote:
> Hello Vignesh,
>
> added Simon to cc...
>
> Am 28.07.2016 um 07:54 schrieb Vignesh R:
>>
>>
>>
>> On Tuesday 26 July 2016 11:53 AM, Heiko Schocher wrote:
>>>
>>> Hello Vignesh,
>>>
>>> Am 25.07.2016 um 12:56 schrieb Vignesh R:
>>>>
>>>> As I2C can be used before DRAM initialization for reading EEPROM,
>>>> avoid using static variables stored in BSS, since BSS is in DRAM, which
>>>> may not have been initialised yet. Explicitly mark "static global"
>>>> variables as belonging to the .data section.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>>>> ---
>>>>    drivers/i2c/i2c-uclass-compat.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>> Acked-by: Heiko Schocher<hs at denx.de>
>>>
>>
>> Thanks! Would you be picking up this patch?
>
>
> The patch is delegated to Simon, if Simon as no objections I can
> pick it up.
>

Yes please.

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list