[U-Boot] [PATCH 0/3] Some Kconfig move/fixups

[Masahiro Yamada]

2016-08-01 2:21 GMT+09:00 Tom Rini <trini at konsulko.com>:
> On Mon, Aug 01, 2016 at 01:24:21AM +0900, Masahiro Yamada wrote:
>> Hi Tom,
>>
>>
>> 2016-07-25 23:55 GMT+09:00 Tom Rini <trini at konsulko.com>:
>> > On Mon, Jul 25, 2016 at 10:06:05PM +0900, Masahiro Yamada wrote:
>> >
>> >>
>> >> Masahiro Yamada (3):
>> >>   cmd: bootz: make CMD_BOOTZ depend on CMD_BOOTM
>> >>   cmd: booti: move CONFIG_CMD_BOOTI to Kconfig
>> >
>> > After a quick skim of the code, I think we could split bootz/booti into
>> > cmd/boot[zi].c and this I think might have been why I didn't make sure
>> > that CMD_BOOT[ZI] depended on CMD_BOOTM in the first place.  Can you
>> > re-work them that way?  Thanks!
>> >
>>
>> bootz and boom are implemented
>> heavily depending on bootm infrastructure,
>> which is enabled by CONFIG_CMD_BOOTM.
>>
>> ./arch/mips/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/sparc/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/powerpc/lib/Makefile:32:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/openrisc/lib/Makefile:8:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/arm/lib/Makefile:29:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/arm/lib/Makefile:30:obj-$(CONFIG_CMD_BOOTM) += zimage.o
>> ./arch/nios2/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/m68k/lib/Makefile:12:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/nds32/lib/Makefile:13:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/microblaze/lib/Makefile:8:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/sh/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/sandbox/lib/Makefile:14:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/x86/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/avr32/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>> ./arch/arc/lib/Makefile:26:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>
> Right, and in the cases where bootz/booti makes sense we should also add
> in:
> obj-$(CONFIG_CMD_BOOTZ) += bootm.o
> and a comment about common infrastructure.
>
>> ./cmd/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
>
> Right, and this gets split into 3 files.
>
>> ./common/Makefile:28:obj-$(CONFIG_CMD_BOOTM) += bootm.o bootm_os.o
>
> And we include these also for CONFIG_CMD_BOOTZ / CMD_BOOTI.  Duplicates
> are OK, they get sorted, I would swear..
>


I'd hand over this task to somebody.

This is too much burden for me
and I do not volunteer to what I do not want to do.


-- 
Best Regards
Masahiro Yamada