[U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries
Simon Glass
sjg at chromium.org
Mon Aug 1 20:22:29 CEST 2016
On 27 July 2016 at 21:28, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Jul 27, 2016 at 08:33:05PM -0600, Simon Glass wrote:
>
>> The current code for setting up the toolchain config always writes the new
>> paths to an item called 'toolchain'. This means that it will overwrite any
>> existing toolchain item with the same name. In practice, this means that:
>>
>> buildman --fetch-arch all
>>
>> will fetch all toolchains, but only the path of the final one will be added
>> to the config. This normally works out OK, since most toolchains are the
>> same version (e.g. gcc 4.9) and will be found on the same path. But it is
>> not correct and toolchains for archs which don't use the same version will
>> not function as expected.
>>
>> Adjust the code to use a complete glob of the toolchain path.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Reviewed-by: Tom Rini <trini at konsulko.com>
>
> --
> Tom
Applied to u-boot-dm
More information about the U-Boot
mailing list