[U-Boot] [PATCH 2/2] fs/fat: Optimizes memory size with single global variable instead of 3

[Benoît Thébaudeau]

Hi,

On Tue, Aug 2, 2016 at 8:53 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 07/28/2016 12:11 AM, Tien Fong Chee wrote:
>>
>> Single 64KB get_contents_vfatname_block global variable would be used for
>> all FAT implementation instead of allocating additional two global
>> variables
>> which are get_denfromdir_block and do_fat_read_at_block. This
>> implementation
>> can help in saving up 128KB memory space.
>
>
> The series,
>
> Tested-by: Stephen Warren <swarren at nvidia.com>
> (via DFU's FAT reading/writing on various Tegra; likely primarily FAT rather
> than VFAT though)
>
> Reviewed-by: Stephen Warren <swarren at nvidia.com>

I suspect that reading a filename with VFAT entries crossing a cluster
boundary in a FAT32 root directory will be broken by this series. I do
not have time to test this and other corner cases right now though,
but it will be possible in the next few weeks.

Best regards,
Benoît