[U-Boot] [PATCH 8/9] mmc: tegra: port to standard clock/reset APIs

[Simon Glass]

Hi Stephen,

On 1 August 2016 at 09:50, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 07/31/2016 08:20 PM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 27 July 2016 at 15:24, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>>
>>> From: Stephen Warren <swarren at nvidia.com>
>>>
>>> Tegra186 supports the new standard clock and reset APIs. Older Tegra SoCs
>>> still use custom APIs. Enhance the Tegra MMC driver so that it can
>>> operate
>>> with either set of APIs.
>>>
>>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>>> Cc: Pantelis Antoniou <panto at antoniou-consulting.com>
>>> ---
>>>  arch/arm/include/asm/arch-tegra/tegra_mmc.h |  8 ++++-
>>>  drivers/mmc/tegra_mmc.c                     | 55
>>> ++++++++++++++++++++++++-----
>>>  2 files changed, 53 insertions(+), 10 deletions(-)
>>
>>
>> Shouldn't we fix up the code to all use the new APIs?
>
>
> Eventually yes. However, that's something that will take a lot of work. When
> similar common APIs were introduced into Linux, there was a transition
> period of 1-2 years where new code was immediately written to the new APIs,
> and old code (e.g. legacy clock API implementation, and its callers) was
> slowly converted. I would expect the same thing in U-Boot; any other
> approach means preventing new work until the conversions are complete, which
> would be rather stagnating.

I still don't like the #ifdefs? Does Linux have #ifdefs in the mmc driver?

Also the work to convert to CONFIG_BLK, CONFIG_DM_MMC_OPS is not a lot of work.

Regards,
Simon