[U-Boot] [PATCH 1/2] mmc: sdhci: remove the unused argument for sdhci_setup_cfg

Simon Glass sjg at chromium.org
Thu Aug 4 06:21:08 CEST 2016


Hi Jaehoon,

On 3 August 2016 at 20:43, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> On 08/04/2016 11:40 AM, Simon Glass wrote:
>> Hi Jaehoon,
>>
>> On 3 August 2016 at 20:38, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>>> Hi Simon,
>>>
>>> On 08/04/2016 11:35 AM, Simon Glass wrote:
>>>> Hi Jaehoon,
>>>>
>>>> On 31 July 2016 at 20:20, Simon Glass <sjg at chromium.org> wrote:
>>>>> On 26 July 2016 at 04:06, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>>>>>> buswidth isn't used anywhere in sdhci_setup_cfg.
>>>>>>
>>>>>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>>>>>> ---
>>>>>>  drivers/mmc/msm_sdhci.c  | 4 ++--
>>>>>>  drivers/mmc/sdhci.c      | 4 ++--
>>>>>>  drivers/mmc/zynq_sdhci.c | 2 +-
>>>>>>  include/sdhci.h          | 3 +--
>>>>>>  4 files changed, 6 insertions(+), 7 deletions(-)
>>>>>
>>>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>>
>>>> Are you going to pick this up? I suggest that it goes in now since it
>>>> will affect people porting drivers.
>>>
>>> I think it's related with DM side. So if you can pick this, I'm ok.
>>> Otherwise, i will apply on u-boot-mmc, today..And tomorrow i will request pull.
>>
>> Yes it is DM-related, but if you don't mind I think it would be good
>> for you to pick these up.
>
> Ok, I will do. And tomorrow, I will request pull to Tom for u-boot-mmc with other mmc patches.
> How about?

Sounds good thank you.

- Simon


More information about the U-Boot mailing list