[U-Boot] [PATCH 1/2 RESEND] fdt_support: fdt_translate_address() blob const correctness

Simon Glass sjg at chromium.org
Sat Aug 6 05:36:09 CEST 2016


Hi Stephen,

On 5 August 2016 at 19:41, Simon Glass <sjg at chromium.org> wrote:
>
> On 5 August 2016 at 09:47, Stephen Warren <swarren at wwwdotorg.org> wrote:
> > From: Stephen Warren <swarren at nvidia.com>
> >
> > The next patch will call fdt_translate_address() from somewhere with a
> > "const void *blob" rather than a "void *blob", so fdt_translate_address()
> > must accept a const pointer too. Constify the minimum number of function
> > parameters to achieve this.
> >
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> > Acked-by: Simon Glass <sjg at chromium.org>
> > ---
> > Re-sending since these didn't show up in patchwork for some reason.
> >
> > This series will be a dependency for the Tegra BPMP driver.
> >
> >  common/fdt_support.c  | 19 ++++++++++---------
> >  include/fdt_support.h |  5 +++--
> >  2 files changed, 13 insertions(+), 11 deletions(-)
>
> Applied to u-boot-dm, thanks!

Unfortunately these patches cause some build breakages. Can you please
take a look?

$ buildman -b dm-push -se
...
02: fdt_support: fdt_translate_address() blob const correctness
      mips:  +   malta64 malta64el maltael malta
+   .match = of_bus_isa_match,
+   ^
w+../common/fdt_support.c:1113:3: warning: initialization from
incompatible pointer type
w+../common/fdt_support.c:1113:3: warning: (near initialization for
'of_busses[0].match')
03: fdt: allow fdtdec_get_addr_size_*() to translate addresses
   aarch64:  +   xilinx_zynqmp_zc1751_xm018_dc4 xilinx_zynqmp_zcu102
xilinx_zynqmp_zc1751_xm015_dc1 xilinx_zynqmp_zc1751_xm019_dc5
xilinx_zynqmp_zc1751_xm016_dc2 xilinx_zynqmp_ep
xilinx_zynqmp_zcu102_revB
       arm:  +   socfpga_de0_nano_soc uniphier_pro4 uniphier_ld4_sld8
zynq_zc770_xm010 zynq_zc770_xm013 zynq_zc770_xm012 zynq_zc706
evb-rk3288 socfpga_arria5 zynq_zybo rock2 socfpga_socrates
uniphier_sld3 zynq_microzed socfpga_sr1500 chromebook_jerry zynq_zed
socfpga_sockit zynq_zc702 socfpga_is1 zynq_picozed fennec-rk3288
zynq_zc770_xm011 popmetal-rk3288 socfpga_mcvevk socfpga_cyclone5
socfpga_vining_fpga uniphier_pxs2_ld6b
+lib/built-in.o: In function `fdtdec_get_addr_size_fixed':
+build/../lib/fdtdec.c:117: undefined reference to `fdt_translate_address'

Regards,
Simon


More information about the U-Boot mailing list