[U-Boot] [PATCH 0/2] rockchip: Initial RK3368 and GeekBox support

Andreas Färber afaerber at suse.de
Sat Aug 6 18:05:29 CEST 2016


Hi Simon,

Am 06.08.2016 um 06:30 schrieb Simon Glass:
> Hi Andreas,
> 
> On 17 July 2016 at 19:06, Andreas Färber <afaerber at suse.de> wrote:
>> Hi,
>>
>> This series adds initial support for RK3368 SoC and GeekBox.
>> For more details see the commit message.
>>
>> Will need to be rebased onto Heiko's cleanups and Kever's RK3399 series.
>>
>> Regards,
>> Andreas
>>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Kever Yang <kever.yang at rock-chips.com>
>> Cc: Heiko Stübner <heiko at sntech.de>
>>
>> Andreas Färber (2):
>>   dts: Import rk3368-geekbox.dts
>>   ARM64: rockchip: Add initial support for RK3368 based GeekBox
>>
> 
> Are you planning to respin these patches?

Eventually...?

> I'd like to get them applied soon.

And I'd like to get my work recognized! However, despite our previous
IRC chat, I had to find out _while_ replying to the rk3399 mails that
you had once again not just applied all patches (twenty minutes after
ack'ing them on a Saturday) but already sent a pull on Tuesday my
nighttime that I was not CC'ed on and that Tom has merged the night
after. So it feels like I'm wasting my time here and consequently I
stopped my review and rebase.

Not only that it's too late for the patches themselves, but Wolfgang
also publishes statistics of Reviewed-bys, which we can't add to commits
after merging. If you as maintainer don't give people who spent time
providing serious review comments sufficient chance to add their
Reviewed-by - and a weekend of absence is certainly something to cope
with since you said you were away end of that week as well - it becomes
a distorted, non-telling statistic. So I am kindly suggesting that
Wolfgang drops the Reviewed-by statistics if maintainers don't care for
them and instead we just all do ugly fix-ups so that we can at least get
recognition in the Signed-off-by statistics.

While we're only talking about 4 tags here, it's a matter of principle
and respect.

Thanks,
Andreas

> 
> Thanks,
> Simon
[snip]

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)


More information about the U-Boot mailing list