[U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available

Stefan Roese sr at denx.de
Tue Aug 9 07:37:26 CEST 2016


Hi Simon,

On 08.08.2016 23:44, Simon Glass wrote:
> On 8 August 2016 at 08:45, Heiko Schocher <hs at denx.de> wrote:
>> Hello Simon,
>>
>>
>> Am 07.08.2016 um 08:54 schrieb Bin Meng:
>>>
>>> On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass <sjg at chromium.org> wrote:
>>>>
>>>> If intel_i2c_bind() is called before relocation there is no BSS section
>>>> available. Use the data section instead, which is always available.
>>>>
>>>> A better fix might be to use global_data, perhaps a new member in
>>>> x86's struct arch_global_data. Comments welcome.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> ---
>>>>
>>>>   drivers/i2c/intel_i2c.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>
>>
>> Hmm... I see no i2c_bind() in mainline U-Boot drivers/i2c/intel_i2c.c
>> driver ?
>>
>> Is this patch and also patch:
>> http://patchwork.ozlabs.org/patch/656335/
>>
>> dependend on another patch(or patchserie) ?
>
> Yes it depends on Stefan's x86 i2c driver. He asked me to take a look.
> It can be squashed in - will leave this to Stefan.

I have squashed it in v2 of the SMBus I2C driver patch which will
hit the list very soon.

Thanks,
Stefan
Avoid


More information about the U-Boot mailing list