[U-Boot] [PATCH v2 07/22] sf: Adopt flash table INFO macro from Linux

Jagan Teki jteki at openedev.com
Wed Aug 10 07:09:13 CEST 2016


On Wednesday 10 August 2016 10:34 AM, Vignesh R wrote:
>
>
> On Wednesday 10 August 2016 01:33 AM, Jagan Teki wrote:
>> INFO macro make flash table entries more adjustable like
>> adding new flash_info attributes, update ID length bytes
>> and so on and more over it will sync to Linux way of defining
>> flash_info attributes.
> [...]
>> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
>> index 7f6e9ae..58d5a6a 100644
>> --- a/drivers/mtd/spi/spi_flash.c
>> +++ b/drivers/mtd/spi/spi_flash.c
>> @@ -924,6 +924,31 @@ static int micron_quad_enable(struct spi_flash *flash)
>>  }
>>  #endif
>>
>> +static const struct spi_flash_params *spi_flash_read_id(struct spi_flash *flash)
>> +{
>> +	int				tmp;
>> +	u8				id[5];
>> +	const struct spi_flash_params	*params;
>> +
>> +	tmp = spi_flash_cmd(flash->spi, CMD_READ_ID, id, 5);
>> +	if (tmp < 0) {
>> +		printf("SF: error %d reading JEDEC ID\n", tmp);
>> +		return ERR_PTR(tmp);
>> +	}
>> +
>
> Could we have debug() to print the JEDEC IDs read as before?

Not necessary, and anyway jedec id is printing in failure/unsupported case.


More information about the U-Boot mailing list