[U-Boot] ext4 write support and big-endian machines

Tom Rini trini at konsulko.com
Wed Aug 10 13:29:15 CEST 2016


On Wed, Aug 10, 2016 at 09:53:03AM +0200, Michael Walle wrote:
> Am 2016-08-05 14:06, schrieb Michael Walle:
> >there doesn't seem to be a dedicated filesystem maintainer, but I've
> >included the original committer for the ext4 write support.
> >
> >I guess the ext4 write support does not work on big-endian machines.
> >As far as I see, almost no fields of the ext4 structures within the
> >write code are byteswapped. That is very unfortunate ;)
> >If I understand the code correctly, the fields are swapped on every
> >access individually. This means we have to go through the "ext4 write"
> >code and look at every field which is accessed and add an appropriate
> >le{16,32}_to_cpu() call.  Puh ;)
> >
> >Btw. is the kernel style le16_to_cpu preferred to __le16_to_cpu()?
> 
> ping anyone?

Yes, le16_to_cpu() is preferred.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160810/e125adc7/attachment.sig>


More information about the U-Boot mailing list