[U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

[york sun]

I am not suggesting remove the macros. Please try to compile after applying first patch. You will see the errors

York


-------- Original Message --------
From: Shengzhou Liu <shengzhou.liu at nxp.com>
Sent: Thursday, August 11, 2016 08:44 PM
To: york sun <york.sun at nxp.com>,u-boot at lists.denx.de
Subject: RE: [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver


> -----Original Message-----
> From: york sun
> Sent: Friday, August 12, 2016 3:45 AM
> To: Shengzhou Liu <shengzhou.liu at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver
>
> > +#define CMD_ADDR_MSB_MR_OP(x) (x << 24)
> > +#define CMD_ADDR_LSB_MR_ADDR(x) (x << 16)
> > +#define MDSCR_DISABLE_CFG_REQ   (0 << 15)
> > +#define MDSCR_ENABLE_CON_REQ (1 << 15)
> > +#define MDSCR_CON_ACK (1 << 14)
> > +#define MDSCR_WL_EN (1 << 9)
> > +#define CMD_NORMAL (0 << 4)
> > +#define CMD_PRECHARGE (1 << 4)
> > +#define CMD_AUTO_REFRESH (2 << 4)
> > +#define CMD_LOAD_MODE_REG (3 << 4)
> > +#define CMD_ZQ_CALIBRATION (4 << 4)
> > +#define CMD_PRECHARGE_BANK_OPEN (5 << 4)
> > +#define CMD_MRR (6 << 4)
> >  #define CMD_BANK_ADDR_0 0x0
> >  #define CMD_BANK_ADDR_1 0x1
> >  #define CMD_BANK_ADDR_2 0x2
>
> Removing those macros causes compiling error for ls1012afrdm_qspi
> ls1012aqds_qspi ls1012ardb_qspi. Please rearrange the change.
>
> York

Why do you want to remove those macros? They are needed and useful, I compiled it for ls1012a QDS/ RDB/FRDM without any issue, and worked fine on boards.

Shengzhou