[U-Boot] [U-Boot, RFC:, v2] tools/env: ensure environment starts at erase block boundary

Tom Rini trini at konsulko.com
Tue Aug 16 03:11:19 CEST 2016

On Thu, Aug 11, 2016 at 09:39:17PM +0200, Andreas Fenkart wrote:

> 56086921 added support for unaligned environments access.
> U-boot itself does not support this:
> - env_nand.c fails when using an unaligned offset. It produces an
>   error in nand_erase_opts{drivers/mtd/nand/nand_util.c}
> - in env_sf/env_flash the unused space at the end is preserved, but
>   not in the beginning. block alignment is assumed
> - env_sata/env_mmc aligns offset/length to the block size of the
>   underlying device. data is silently redirected to the beginning of
>   a block
> There is seems no use case for unaligned environment. If there is
> some useful data at the beginning of the the block (e.g. end of u-boot)
> that would be very unsafe. If the redundant environments are hosted by
> the same erase block then that invalidates the idea of double buffering.
> It might be that unaligned access was allowed in the past, and that
> people with legacy u-boot are trapped. But at the time of 56086921
> it wasn't supported and due to reasons above I guess it was never
> introduced.
> I prefer to remove that (unused) feature in favor of simplicity
> Signed-off-by: Andreas Fenkart <andreas.fenkart at digitalstrom.com>
> Acked-by: Stefan Agner <stefan.agner at toradex.com>

Applied to u-boot/master, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160815/5d9cae0e/attachment.sig>

More information about the U-Boot mailing list