[U-Boot] [PATCH v3 00/27] spi/sf: Updates on flash detection

[Bin Meng]

Hi Jagan,

On Mon, Aug 15, 2016 at 6:09 PM, Jagan Teki <jagannadh.teki at gmail.com> wrote:
> Hi Bin,
>
> On 12 August 2016 at 23:28, Jagan Teki <jagannadh.teki at gmail.com> wrote:
>> On 12 August 2016 at 04:37, york sun <york.sun at nxp.com> wrote:
>>> I saw some errors when compiling for arm. Compiling for power is still
>>> going.
>>
>> Can you please try again?
>
> Please let me know in case if you find any buildman issues?
>

I am not sure why you can't run buildman yourself. You are the
u-boot-spi maintainer and you need make sure every commit builds
without any warnings or errors. Anyway, here are some logs:

+../drivers/spi/atmel_spi.c:17:31: error: asm/arch/at91_spi.h: No such
file or directory
+../drivers/spi/atmel_spi.c:18:22: error: asm/gpio.h: No such file or directory
+make[2]: *** [drivers/spi/atmel_spi.o] Error 1
+make[1]: *** [drivers/spi] Error 2

+  ext_jedec = idcode[3] << 8 | idcode[4];
+  if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL ||
+     ^
+  jedec = idcode[1] << 8 | idcode[2];
+        ^
+                    ^
+                                           ^
+../drivers/mtd/spi/spi_flash.c: In function ‘spi_flash_scan’:
+../drivers/mtd/spi/spi_flash.c:1088: warning: ‘idcode[0]’ may be used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1049: warning: ‘idcode[4]’ may be used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1049: warning: ‘idcode[3]’ may be used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1048: warning: ‘idcode[2]’ may be used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1048: warning: ‘idcode[1]’ may be used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1042: warning: ‘ret’ may be used
uninitialized in this function
+  int ret;
+      ^
+../drivers/mtd/spi/spi_flash.c: In function 'spi_flash_scan':
+../drivers/mtd/spi/spi_flash.c:1088: warning: 'idcode[0]' is used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1049: warning: 'idcode[4]' is used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1049: warning: 'idcode[3]' is used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1048: warning: 'idcode[2]' is used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1048: warning: 'idcode[1]' is used
uninitialized in this function
+../drivers/mtd/spi/spi_flash.c:1042: warning: 'ret' may be used
uninitialized in this function

w+../drivers/mtd/spi/spi_flash.c:1043:13: warning: variable
'ext_jedec' set but not used [-Wunused-but-set-variable]
w+../drivers/mtd/spi/spi_flash.c:1043:6: warning: variable 'jedec' set
but not used [-Wunused-but-set-variable]
w+../drivers/mtd/spi/spi_flash.c:1045:6: warning: 'ret' may be used
uninitialized in this function [-Wmaybe-uninitialized]

Regards,
Bin