[U-Boot] [U-Boot, v4, 01/13] cmd: fdt: Narrow the check for fdt addr

Jaehoon Chung jh80.chung at samsung.com
Tue Aug 16 03:52:04 CEST 2016


Hi,

On 07/05/2016 05:26 PM, Maxime Ripard wrote:
> The current code only checks if the fdt subcommand is fdt addr by checking
> whether it starts with 'a'.
> 
> Since this is a pretty widely used letter, narrow down that check a bit.
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> Acked-by: Pantelis Antoniou <pantelis.antoniou at konsulko.com>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>

I don't know what these patchset were delegated to me..I think it's not my scope.
Simon is FDT maintainer..Could you check these patch-set?

Best Regards,
Jaehoon Chung

> ---
>  cmd/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/fdt.c b/cmd/fdt.c
> index 898217ffe5f8..0f5923e75a41 100644
> --- a/cmd/fdt.c
> +++ b/cmd/fdt.c
> @@ -87,7 +87,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  	/*
>  	 * Set the address of the fdt
>  	 */
> -	if (argv[1][0] == 'a') {
> +	if (strncmp(argv[1], "ad", 2) == 0) {
>  		unsigned long addr;
>  		int control = 0;
>  		struct fdt_header *blob;
> 



More information about the U-Boot mailing list