[U-Boot] [PATCH 0/5] ARM: Enable CMD_TIME on all TI platforms

[Lokesh Vutla]

On Thursday 11 August 2016 07:01 PM, Tom Rini wrote:
> On Thu, Aug 11, 2016 at 06:39:12PM +0530, Lokesh Vutla wrote:
> 
>> This series enables CMD_TIME on all TI platforms.
>>
>> Lokesh Vutla (5):
>>   configs: am335x: Enable CMD_TIME
>>   configs: am43xx: Enable CMD_TIME
>>   configs: am57xx: Enable CMD_TIME
>>   configs: dra7xx: Enable CMD_TIME
>>   configs: ks2: Enable CMD_TIME
>>
>>  configs/am335x_boneblack_defconfig        | 1 +
>>  configs/am335x_evm_defconfig              | 1 +
>>  configs/am335x_evm_nor_defconfig          | 1 +
>>  configs/am335x_evm_norboot_defconfig      | 1 +
>>  configs/am335x_evm_spiboot_defconfig      | 1 +
>>  configs/am335x_evm_usbspl_defconfig       | 1 +
>>  configs/am43xx_evm_defconfig              | 1 +
>>  configs/am43xx_evm_ethboot_defconfig      | 1 +
>>  configs/am43xx_evm_qspiboot_defconfig     | 1 +
>>  configs/am43xx_evm_usbhost_boot_defconfig | 1 +
>>  configs/am43xx_hs_evm_defconfig           | 1 +
>>  configs/am57xx_evm_defconfig              | 1 +
>>  configs/am57xx_hs_evm_defconfig           | 1 +
>>  configs/dra7xx_evm_defconfig              | 1 +
>>  configs/dra7xx_hs_evm_defconfig           | 1 +
>>  configs/k2e_evm_defconfig                 | 1 +
>>  configs/k2g_evm_defconfig                 | 1 +
>>  configs/k2hk_evm_defconfig                | 1 +
>>  configs/k2l_evm_defconfig                 | 1 +
>>  19 files changed, 19 insertions(+)
> 
> This would have been a 1 line change to
> include/configs/ti_armv7_common.h and is now 19 files and 19 lines, so a

IIRC, this solution was rejected as CMD_TIME has Kconfig and has to be
enabled in defconfig.

> step backwards.  Further, this isn't a SoC thing, it's a TI eval
> platform consistency (and I imagine testing) thing.  I think it's time
> to look at adding in board/ti/Kconfig (and other vendors too given the
> existing include/configs/*common* files) for style things that don't
> belong in arch/arm/cpu/armv7/omap-common/Kconfig (which needs to get
> moved to arch/arm/mach-omap to match other platforms, yes) in this case.
> 
> The first patch to introduce board/ti/Kconfig will be "big" as the
> board/ti/*/Kconfig will need to bring it in but follow up migration of
> stuff out of include/configs/ti_*common.h will be smaller.

Okay, ill work on this.

Thanks and regards,
Lokesh

> 
> Thanks!
>