[U-Boot] [PATCH 2/5] mmc: initialize mmc_cmd with 0

[Simon Glass]

Hi Peng,

On 12 August 2016 at 19:41, Peng Fan <van.freenix at gmail.com> wrote:
> Hi Simon,
> On Fri, Aug 12, 2016 at 11:20:25AM -0600, Simon Glass wrote:
>>Hi Peng,
>>
>>On 11 August 2016 at 05:00, Peng Fan <van.freenix at gmail.com> wrote:
>>> Using {0} to initialize mmc_cmd, before filling the structure.
>>>
>>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>>> Cc: Jaehoon Chung <jh80.chung at samsung.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> Cc: Bin Meng <bmeng.cn at gmail.com>
>>> Cc: Stefan Wahren <stefan.wahren at i2se.com>
>>> Cc: Clemens Gruber <clemens.gruber at pqgruber.com>
>>> Cc: Kever Yang <kever.yang at rock-chips.com>
>>> Cc: Eric Nelson <eric at nelint.com>
>>> Cc: Stephen Warren <swarren at nvidia.com>
>>> ---
>>>  drivers/mmc/mmc.c       | 28 ++++++++++++++--------------
>>>  drivers/mmc/mmc_write.c |  4 ++--
>>>  2 files changed, 16 insertions(+), 16 deletions(-)
>>
>>Why is this needed? Does it affect code size?
>
> I add a timeout entry in mmc_cmd, but I do not want to specify a value for timeout
> for each mmc_cmd. So I use {0}.
>
> Then to those who want use timeout, a value can be assigned to timeout, just like
> I added in the patchset for mmc erase.

Instead of that, can you assign the value to 0, or whatever you want?
You might want to have a helper like mmc_init_cmd() to zero things
out.

Regards,
Simon