[U-Boot] [PATCH v1] cmd/sf: probe flash with speed of last known flash or speed from devicetree

[Vignesh R]

On Thursday 25 August 2016 03:02 PM, Hannes Schmelzer wrote:
> On 08/25/2016 10:39 AM, Vignesh R wrote:
>>
>> On Wednesday 24 August 2016 07:40 PM, Hannes Schmelzer wrote:
>>> On 08/24/2016 02:21 PM, Hannes Schmelzer wrote:
>>>> On 08/24/2016 01:12 PM, Vignesh R wrote:
>>>>> On Wednesday 24 August 2016 04:21 PM, Hannes Schmelzer wrote:
>>>>>> On 08/24/2016 12:35 PM, Vignesh R wrote:
>> [...]
>>
>>>>> AFAIU, saveenv() uses CONFIG_ENV_SPI_MAX_HZ only when
>>>>> CONFIG_DM_SPI_FLASH is not defined. Could please explain how
>>>>> CONFIG_ENV_SPI_MAX_HZ takes precedence over spi-max-frequency
>>>>> during sf
>>>>> probe?
>>>> Thanks the discussion, I think we coming closer to the problem.
>>>> Your'e right saveenv() behaves as you described, but not so
>>>> env_relocate_spec().
>>>>
>>>> There the flash is probed like this:
>>>>      env_flash = spi_flash_probe(CONFIG_ENV_SPI_BUS, CONFIG_ENV_SPI_CS,
>>>>              CONFIG_ENV_SPI_MAX_HZ, CONFIG_ENV_SPI_MODE);
>>>>
>>>> and thats the point where some existing dt node becomes modified with
>>>> those values. Thats probably wrong doing so.
>>>>
>>>> I think there should be same logic applied as in saveen().
>>> Tested again, and confirming this behaviour.
>> Yeah, I think relocate_spec() was not updated during dm conversion.
> looks like, should i submit some patch?

Patches are welcome. Please Cc U-Boot SPI maintainer Jagan Teki
<jteki at openedev.com>.  Thanks!

-- 
Regards
Vignesh