[U-Boot] [PATCH 02/42] moveconfig: Add an option to commit changes

[Simon Glass]

Hi Masshiro,

On 24 August 2016 at 19:40, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> 2016-08-25 1:51 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> The moveconfig tool is quite clever and generally produces results that
>> are suitable for sending as a patch without further work. The main required
>> step is to add the changes to a commit.
>>
>> Add an option to do this automatically. This allows moveconfig to be used
>> from a script to convert multiple CONFIG options, once per commit.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
>
>
> Isn't it possible to do this in your script?
>
>
> BTW, I assume you want this feature
> for convert & git-commit per option.
>
>
> In my opinion, you do not have to split to
> per-option patches.
>
>
> You can move multiple options at once.
>
>
> tools/moveconfig SPL_DM  SPL_RSA  SPL_CRYPTO_SUPPORT ...

Yes of course, but as you can see from your other comments, some
changes are simple and others result in comments and rework. It seems
better to deal with each change individually unless they really are
simple.

Most of these changes affect a lot of boards. If there is a run-time
breakage it helps a lot if a bisect can pinpoint the change exactly.

>
>
> Then, git commit and list all the moved options in the commit log.

OK. I think the moveconfig tool should handle committing changes since
it can do a better job of creating a sensible commit message.

Regards,
Simon