[U-Boot] [PATCH v3 12/13] ext4: Use correct value for inode size even on revision 0 filesystems

Lukasz Majewski l.majewski at samsung.com
Mon Aug 29 16:09:43 CEST 2016


Hi Stefan,

> fs->inodesz is already correctly (i.e. dependent on fs revision)
> initialized in ext4fs_mount.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> ---
>  fs/ext4/ext4_write.c | 1 -
>  include/ext_common.h | 2 --
>  2 files changed, 3 deletions(-)
> 
> v3: Patch added to series
> 
> diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c
> index 5e208ef..81a750b 100644
> --- a/fs/ext4/ext4_write.c
> +++ b/fs/ext4/ext4_write.c
> @@ -609,7 +609,6 @@ int ext4fs_init(void)
>  
>  	/* populate fs */
>  	fs->blksz = EXT2_BLOCK_SIZE(ext4fs_root);
> -	fs->inodesz = INODE_SIZE_FILESYSTEM(ext4fs_root);
>  	fs->sect_perblk = fs->blksz >> fs->dev_desc->log2blksz;
>  
>  	/* get the superblock */
> diff --git a/include/ext_common.h b/include/ext_common.h
> index 4cd2aa7..25216ca 100644
> --- a/include/ext_common.h
> +++ b/include/ext_common.h
> @@ -52,8 +52,6 @@
>  #define LOG2_BLOCK_SIZE(data)
> (le32_to_cpu		   \ (data->sblock.log2_block_size) \
>  				    + EXT2_MIN_BLOCK_LOG_SIZE)
> -#define INODE_SIZE_FILESYSTEM(data)	(le16_to_cpu \
> -			(data->sblock.inode_size))
>  
>  #define EXT2_FT_DIR	2
>  #define SUCCESS	1

Reviewed-by: Lukasz Majewski <l.majewski at samsung.com> 

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list