[U-Boot] [PATCH 1/7] include: image.h: Fixes build warning with CONFIG_FIT_IMAGE_POST_PROCESS

[Andrew F. Davis]

On 08/26/2016 01:30 AM, Madan Srinivas wrote:
> The function board_fit_image_post_process is defined only when the config

I think you mean "declared" here, it is "defined" when ether
CONFIG_SPL_FIT_IMAGE_POST_PROCESS *or* CONFIG_FIT_IMAGE_POST_PROCESS is
enabled, but only "declared" here in this header when the first is enabled.

> CONFIG_FIT_IMAGE_POST_PROCESS is enabled. For secure systems that do not
> use SPL but use FIT kernel images, only CONFIG_FIT_IMAGE_POST_PROCESS will

I think you are missing a word here. (will {be} defined)

> defined, which will result in an implicit declaration of function
> 'board_fit_image_post_process' warning while building u-boot. This
> patch fixes this warning.
> 
> Signed-off-by: Madan Srinivas <madans at ti.com>

Otherwise looks good to me,

Acked-by: Andrew F. Davis <afd at ti.com>

> ---
> 
>  include/image.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/image.h b/include/image.h
> index 64da722..6884421 100644
> --- a/include/image.h
> +++ b/include/image.h
> @@ -1245,7 +1245,8 @@ void android_print_contents(const struct andr_img_hdr *hdr);
>   */
>  int board_fit_config_name_match(const char *name);
>  
> -#ifdef CONFIG_SPL_FIT_IMAGE_POST_PROCESS
> +#if defined(CONFIG_SPL_FIT_IMAGE_POST_PROCESS) || \
> +	defined(CONFIG_FIT_IMAGE_POST_PROCESS)
>  /**
>   * board_fit_image_post_process() - Do any post-process on FIT binary data
>   *
>