[U-Boot] [PATCH v2 2/3] x86: efi: Fix EFI 64-bit payload build warnings

Bin Meng bmeng.cn at gmail.com
Tue Aug 30 03:29:03 CEST 2016


On Tue, Aug 30, 2016 at 3:38 AM, Simon Glass <sjg at chromium.org> wrote:
> On 25 August 2016 at 02:47, Bin Meng <bmeng.cn at gmail.com> wrote:
>> There are lots of warnings when building EFI 64-bit payload.
>>
>> include/asm-generic/bitops/__fls.h:17:2:
>>   warning: left shift count >= width of type
>>         if (!(word & (~0ul << 32))) {
>>                         ^
>>
>> In fact, U-Boot itself as EFI payload is running in 32-bit mode.
>> So BITS_PER_LONG needs to still be 32, but EFI status codes are
>> 64-bit when booting from 64-bit EFI. Introduce EFI_BITS_PER_LONG
>> to bridge those status codes with U-Boot's BITS_PER_LONG.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Rework the patch to fix 64-bit payload boot issue
>>
>>  arch/x86/include/asm/types.h |  4 ----
>>  include/efi.h                | 32 ++++++++++++++++++++------------
>>  2 files changed, 20 insertions(+), 16 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list