[U-Boot] [RFC PATCH v2 3/8] disk: part: add support of GPT partitioning over MTD

[Simon Glass]

Hi Patrick,

On 30 November 2016 at 04:01, Patrick Delaunay
<patrick.delaunay73 at gmail.com> wrote:
> From: Patrick Delaunay <patrick.delaunay at st.com>
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay73 at gmail.com>
> ---
>
> Changes in v2: None
>
>  Kconfig            |  12 ++
>  disk/part_efi.c    | 445 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  doc/README.gpt.mtd | 189 +++++++++++++++++++++++
>  include/part.h     |  13 +-
>  4 files changed, 657 insertions(+), 2 deletions(-)
>  create mode 100644 doc/README.gpt.mtd

This seems OK to me, but here are some general comments:

- Return -EINVAL or something like that instead of -1
- malloc()/calloc() can fail, so check for NULL and return -ENOMEM
- how about putting your changes todisk/part_efi.c in their own file?

Regards,
Simon