[U-Boot] [PATCH v2 1/3] net: Kconfig: Add CONFIG_MACB option

[Tom Rini]

On Wed, Nov 30, 2016 at 03:48:56PM -0600, Joe Hershberger wrote:
> Hi Tom,
> 
> On Tue, Nov 1, 2016 at 9:06 PM, Wenyou Yang <wenyou.yang at atmel.com> wrote:
> > Add CONFIG_MACB option in KConfig to be used to select the Cadence
> > MACB Ethernet driver.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > ---
> >
> > Changes in v2: None
> >
> >  drivers/net/Kconfig | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 302c005..fc0a10f 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -137,6 +137,16 @@ config MVPP2
> >           This driver supports the network interface units in the
> >           Marvell ARMADA 375 SoC.
> >
> > +config MACB
> > +       bool "Cadence MACB/GEM Ethernet Interface"
> > +       depends on DM_ETH
> > +       select PHYLIB
> > +       help
> > +         The Cadence MACB ethernet interface is found on many Atmel
> > +         AT91 and SAMA5 parts.  This driver also supports the Cadence
> > +         GEM (Gigabit Ethernet MAC) found in some ARM SoC devices.
> > +         Say Y to include support for the MACB/GEM chip.
> > +
> 
> I contend that this patch needs to include running moveconfig, but the
> last time I made that comment, you had some other solution that
> involved some distro default or something. I'd like to apply this
> series, but this is blocking it. Please provide guidance.

OK, this one is small enough that you can fold in doing a moveconfig as
part of applying it.  My concern is that for more wide ranging options
it's a pain to get moveconfig to migrate 100% of the configs and then
ensure that there's no binary size changes.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161130/fd314704/attachment.sig>