[U-Boot] [PATCH 02/17] arm: mvebu: Add gpio support

Stefan Roese sr at denx.de
Thu Dec 1 09:26:32 CET 2016


Hi Mario,

sorry for the late review. A few comments now to the patch
series...

On 23.11.2016 16:12, Mario Six wrote:
> From: Dirk Eibach <dirk.eibach at gdsys.cc>
>
> Add driver interface functions for the GPIO controller on the mvebu
> architecture (based on kirkwood).
>
> Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
> ---
>  arch/arm/mach-mvebu/include/mach/gpio.h | 41 +++++++++++++++++++++++++++++++--
>  1 file changed, 39 insertions(+), 2 deletions(-)

This is no "real" GPIO driver but only adds to the old GPIO
infrastructure. I've added a DM based GPIO driver for MVEBU quite
a while ago:

drivers/gpio/mvebu_gpio.c

Could you please try to use this driver instead? If something
is missing in this driver then please extend this DM driver.

Thanks,
Stefan


More information about the U-Boot mailing list