[U-Boot] [PATCH v2] disk: convert to Kconfig
Patrick DELAUNAY
patrick.delaunay at st.com
Fri Dec 2 18:23:16 CET 2016
Hi Tom
>
> > This converts the following to Kconfig:
> > CONFIG_PARTITIONS
> > CONFIG_MAC_PARTITION
> > CONFIG_DOS_PARTITION
> > CONFIG_ISO_PARTITION
> > CONFIG_AMIGA_PARTITION
> > CONFIG_EFI_PARTITION
> > CONFIG_PARTITION_UUIDS
> > CONFIG_PARTITION_TYPE_GUID
> [snip]
> > 606 files changed, 996 insertions(+), 583 deletions(-)
>
> The insertions to deletions ratio is still high, and I think we can do a little
> better. Some of this is due to platforms that I fix with
> https://patchwork.ozlabs.org/patch/700546/ and will have the various types
> selected now. But I think we can still do a little better with defaults too:
I agree that DISTRO_DEFAULT should reduce the update ratio....
I wait the distro update and propose my patch on the top of https://patchwork.ozlabs.org/patch/700546/ ?
or I continue submission as it ?
> [snip]
> > +config ISO_PARTITION
> > + bool "Enable ISO partition table"
> > + depends on PARTITIONS
>
> This should be default y for x86, along with DOS and MAC.
>
> > +config SPL_ISO_PARTITION
> > + bool "Enable ISO partition table for SPL"
> > + depends on SPL && PARTITIONS
>
> Here and elsewhere, SPL_xxx_PARTITION should be default y if
> xxx_PARTITION
>
> > +config PARTITION_UUIDS
> > + bool "Enable support of UUID for partition"
> > + help
> > + Activate the configuration of UUID for partition
>
> I think a lot of these will go away once CMD_GPT and CMD_PART are
> converted to Kconfig, but I don't want to chicken-and-egg this nor have too
> many things in flight at once, so lets put that off until after this series.
> Thanks!
Yes dependency need to be reviewed when all this command will moved to Kconfig
CMD_GPT => select EFI and PARTITION_UUIDS
CMD_PART => select PARTITION_UUIDS
I will propose v3 with reduced ratio (I hope) but it is more complicated depends rules :
config MAC_PARTITION
default y if PPC || x86 || SPARC || SH
config SPL_MAC_PARTITION
default y if MAC_PARTITION
config DOS_PARTITION
default y if PPC || x86 || CMD_FAT || USB_STORAGE
config SPL_DOS_PARTITION
default y if DOS_PARTITION
config ISO_PARTITION
default y if M68K || PPC || SPARC || MIPS
config SPL_ISO_PARTITION
default y if ISO_PARTITION
config SPL_AMIGA_PARTITION
default y if AMIGA_PARTITION
config SPL_EFI_PARTITION
default y if EFI_PARTITION
> --
> Tom
Regards,
Patrick
More information about the U-Boot
mailing list