[U-Boot] [PATCH 1/5] arm: am57xx: cl-som-am57x: add initial board support

[Uri Mashiach]

Hello Tom,

On 12/01/2016 05:36 PM, Tom Rini wrote:
 > On Thu, Dec 01, 2016 at 10:28:12AM +0200, Uri Mashiach wrote:
 >
 >> From: Dmitry Lifshitz <lifshitz at compulab.co.il>
 >>
 >> Features supported :
 >>
 >> * Serial console
 >> * SPI Flash
 >> * MMC/SD Card
 >> * eMMC storage
 >> * SATA
 >> * PCA9555 - GPIO expander over I2C5 bus
 >> * USB
 >>
 >> Signed-off-by: Dmitry Lifshitz <lifshitz at compulab.co.il>
 >> [uri.mashiach at compulab.co.il: Adjust to v2016.11]
 >> Signed-off-by: Uri Mashiach <uri.mashiach at compulab.co.il>
 >> Acked-by: Igor Grinberg <grinberg at compulab.co.il>
 >
 > In general:
 >
 > Reviewed-by: Tom Rini <trini at konsulko.com>
 >
 > [snip]
 >> +/* Status LED */
 >> +#define CONFIG_STATUS_LED		/* Status LED enabled */
 >> +#define CONFIG_GPIO_LED
 >> +#define CONFIG_BOARD_SPECIFIC_LED
 >> +#define GREEN_LED_DEV			0
 >> +					/* cl_som_am57x Green LED is GPIO2_5 */
 >> +#define GREEN_LED_GPIO			37
 >> +#define STATUS_LED_BIT			GREEN_LED_GPIO
 >> +#define STATUS_LED_STATE		STATUS_LED_ON
 >> +#define STATUS_LED_PERIOD		(CONFIG_SYS_HZ / 2)
 >
 > Do you have time to look at moving CONFIG_STATUS_LED and related defines
 > to Kconfig (or where makes more sense, include/status_led.h) ?  I see
 > this is used on a few CompuLab boards so you'd be able to test the
 > changes as well, thanks!
 >

I prefer that the CL-COM-AM57x module will be included the next release.
The Kconfig migration of the status LED will be sent as a separate patch 
set.
Please let me know which of the following options is preferred:
1. Remove the current patch from the set and add a separate patch after 
the Kconfig migration of the status LED.
2. Leave the current patch in the patch set and send a
separated update patch after the Kconfig migration of the status LED.

-- 
Thabks,
Uri