[U-Boot] [PATCH v3 0/4] mmc: sdhci: Add support for frequency constrained peripheral interfaces

Jaehoon Chung jh80.chung at samsung.com
Mon Dec 5 03:19:24 CET 2016


Hi Stefan,

On 12/02/2016 10:24 PM, stefan.herbrechtsmeier at weidmueller.de wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.de>
> 
> 
> The sdhci controller assumes that the base clock frequency is fully
> supported by the peripheral and doesn't support hardware limitations.
> Distinguish between base clock of the host controller and maximal
> supported peripheral clock frequency of the peripheral interface.
> This is needed for the zynq platform to support two sdhci ports with
> different IO routings.

I understood what your purpose is...When i checked your patch, i wonder one thing about dwmmc controller.
There is also using dwmci_setup_cfg() and it is assigned to cfg->f_min/max with max_clk/min_clk.

I think it also needs to take your approach, right?
do you have any plan for dwmmc controller?

I want to apply at same time..because cfg->f_min/f_max should be used in mmc.c.
so It has to consider about all host controller, not only sdhci controller. :)

Best Regards,
Jaehoon Chung

> 
> Changes in v3:
> - Rename arguments of sdhci_setup_cfg function from max_clk/min_clk to f_max/f_min
> 
> Changes in v2:
> - Remove unused index from get uart clock function
> - Remove unused index from get sdio clock function
> - Introduce common get clock function
> 
> Stefan Herbrechtsmeier (4):
>   mmc: sdhci: Distinguish between base clock and maximum peripheral
>     frequency
>   serial: zynq: Remove unused index from get uart clock function
>   mmc: zynq: Determine base clock frequency via clock framework
>   mmc: zynq: Add fdt max-frequency support
> 
>  arch/arm/mach-zynq/clk.c              | 51 +++++++++++++++++++++++++++--------
>  arch/arm/mach-zynq/include/mach/clk.h |  3 ++-
>  drivers/mmc/atmel_sdhci.c             |  7 +++--
>  drivers/mmc/bcm2835_sdhci.c           |  3 ++-
>  drivers/mmc/ftsdc021_sdhci.c          |  3 ++-
>  drivers/mmc/kona_sdhci.c              |  3 ++-
>  drivers/mmc/msm_sdhci.c               |  2 ++
>  drivers/mmc/mv_sdhci.c                |  3 ++-
>  drivers/mmc/pci_mmc.c                 |  1 +
>  drivers/mmc/pic32_sdhci.c             |  4 ++-
>  drivers/mmc/rockchip_sdhci.c          |  4 +--
>  drivers/mmc/s5p_sdhci.c               |  5 ++--
>  drivers/mmc/sdhci.c                   | 34 ++++++++++++-----------
>  drivers/mmc/spear_sdhci.c             |  3 ++-
>  drivers/mmc/zynq_sdhci.c              | 40 ++++++++++++++++++++++++++-
>  drivers/serial/serial_zynq.c          |  2 +-
>  include/sdhci.h                       | 13 ++++-----
>  17 files changed, 133 insertions(+), 48 deletions(-)
> 



More information about the U-Boot mailing list