[U-Boot] [PATCH v2 3/6] arm64: mvebu: pinctrl: Add pin control driver for A8K family

Simon Glass sjg at chromium.org
Mon Dec 5 07:25:01 CET 2016


Hi Kostya,

On 4 December 2016 at 09:12,  <kostap at marvell.com> wrote:
> From: Konstantin Porotchkin <kostap at marvell.com>
>
> Add a DM port of Marvell pin control driver.
> The A8K SoC family contains several silicone dies interconnected
> in a single package. Every die is normally equipped with its own
> pin controller unit.
> There are 2 pin controllers in A70x0 SoC and 3 in A80x0 SoC.
>
> Changes for v2:
> - Fix the code following Simon's review
> - Code syntax fixes
> - MPP functions documentation for CP110 and APN806
>
> Signed-off-by: Konstantin Porotchkin <kostap at marvell.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Nadav Haklai <nadavh at marvell.com>
> Cc: Neta Zur Hershkovits <neta at marvell.com>
> Cc: Omri Itach <omrii at marvell.com>
> Cc: Igal Liberman <igall at marvell.com>
> Cc: Haim Boot <hayim at marvell.com>
> Cc: Hanna Hawa <hannah at marvell.com>
> ---
>  arch/arm/include/asm/arch-armada8k/soc-info.h      |  17 ++
>  .../pinctrl/marvell,armada-apn806-pinctrl.txt      |  25 ++
>  .../pinctrl/marvell,armada-cp110-pinctrl.txt       | 270 +++++++++++++++++++++
>  .../pinctrl/marvell,mvebu-pinctrl.txt              | 113 +++++++++
>  drivers/pinctrl/Kconfig                            |   1 +
>  drivers/pinctrl/Makefile                           |   1 +
>  drivers/pinctrl/mvebu/Kconfig                      |   7 +
>  drivers/pinctrl/mvebu/Makefile                     |   7 +
>  drivers/pinctrl/mvebu/pinctrl-mvebu.c              | 179 ++++++++++++++
>  drivers/pinctrl/mvebu/pinctrl-mvebu.h              |  31 +++
>  10 files changed, 651 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-armada8k/soc-info.h
>  create mode 100644 doc/device-tree-bindings/pinctrl/marvell,armada-apn806-pinctrl.txt
>  create mode 100644 doc/device-tree-bindings/pinctrl/marvell,armada-cp110-pinctrl.txt
>  create mode 100644 doc/device-tree-bindings/pinctrl/marvell,mvebu-pinctrl.txt
>  create mode 100644 drivers/pinctrl/mvebu/Kconfig
>  create mode 100644 drivers/pinctrl/mvebu/Makefile
>  create mode 100644 drivers/pinctrl/mvebu/pinctrl-mvebu.c
>  create mode 100644 drivers/pinctrl/mvebu/pinctrl-mvebu.h

Reviewed-by: Simon Glass <sjg at chromium.org>

It would be good to have a bit more detail in the Kconfig help about
what the hardware supports, and what your drive supports

- Simon


More information about the U-Boot mailing list