[U-Boot] [PATCH] imx_common: spl: Fix SPL boot from SD card

Stefano Babic sbabic at denx.de
Mon Dec 5 12:47:57 CET 2016


Hi Fabio,

On 02/12/2016 20:05, Fabio Estevam wrote:
> On Fri, Dec 2, 2016 at 3:16 PM, Marcin Niestroj
> <m.niestroj at grinn-global.com> wrote:
> 
>>> If you took the assumption that in "BOOT_DEVICE_MMC1 = Boot from SDHC1
>>> port" in 54e4fcfa3c749a78 ("ARM: mx6: add MMC2 boot device detection
>>> support in SPL") I suggest we need to revert it.
>>>
>>
>> Indeed it was my assumption. I agree it should be reverted then.
> 
> Thanks for confirming.
> 
> Stefano, would you like to take Breno's original patch with the
> revert?

I think it is ok to take Breno's original patch. It was just a
misunderstanding and how boot device order is set was cleared in this
thread.

Best regards,
Stefano Babic


> Or would you like me to resend it with an improved commit log
> explaining the reason for the breakage?
> 
>> So to support booting from two SD/MMC devices one should create
>> board_boot_order() function? That way BOOT_CFG2[3:4] can be read there
>> to figure out which MMC1 or MMC2 should be configured as the first boot
>> device.
> 
> If you want to determine the SD/MMC port dynamically it seems like a solution.
> 
> Or if you always know the SD/MMC port you will boot from then you can
> simply register the associated SDHC port first.
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list