[U-Boot] [PATCH v2 1/6] arm64: mvebu: Modify the A8K SPI and I2C config in DTS

Stefan Roese sr at denx.de
Tue Dec 6 09:31:27 CET 2016


Hi Kosta,

On 06.12.2016 09:26, Kostya Porotchkin wrote:
>> -----Original Message-----
>> From: Stefan Roese [mailto:sr at denx.de]
>> Sent: Tuesday, December 06, 2016 08:13
>> To: Kostya Porotchkin; u-boot at lists.denx.de
>> Cc: Nadav Haklai; Neta Zur Hershkovits; Omri Itach; Igal Liberman; Haim
>> Boot; Hanna Hawa
>> Subject: Re: [PATCH v2 1/6] arm64: mvebu: Modify the A8K SPI and I2C
>> config in DTS
>>
>> Hi Kosta,
>>
>> On 04.12.2016 17:12, kostap at marvell.com wrote:
>>> From: Konstantin Porotchkin <kostap at marvell.com>
>>>
>>> Align the Armada-8040-db and Armada-7040-db SPI and I2C DTS settings
>>> with latest DB settings:
>>> - 8040-db: disable i2c0 and spi0 on AP (MPPs are reserved for SDIO)
>>> - 8040-db: disable cps_i2c0 on CP1
>>> - 8040-db: enable spi1 on CP1 (the new location of the boot flash)
>>>   The spi1 on CP1 is aliased as spi0 since this is the way
>>>   the driver enumerates it.
>>>
>>> Changes for v2:
>>> - 7040-db: remove i2c0 and spi0 entries from AP (MPPs are reserved for
>>> SDIO)
>>>
>>> Signed-off-by: Konstantin Porotchkin <kostap at marvell.com>
>>> Cc: Stefan Roese <sr at denx.de>
>>> Cc: Nadav Haklai <nadavh at marvell.com>
>>> Cc: Neta Zur Hershkovits <neta at marvell.com>
>>> Cc: Omri Itach <omrii at marvell.com>
>>> Cc: Igal Liberman <igall at marvell.com>
>>> Cc: Haim Boot <hayim at marvell.com>
>>> Cc: Hanna Hawa <hannah at marvell.com>
>>> ---
>>
>> Please move the patch version history below this "---" line. By doing
>> this, the history will not be added to the git repository (where it does
>> not really belong). Please do this generally for all your patches
>> please.
> [Konstantin Porotchkin]
> As far as I understand the only way to do so is to edit the output patch file
> produced by "git format-patch".
> If I put the change log into my commit message, it always added before the comment line.
> Is it the right way of handling this kind of comments?

Yes, this is one way of handling this. You can also use the patman
tool (tools/patman/*) to handle your patches. Its especially helpful
when you have to deal with bigger patchsets that likely will undergo
multiple versions. I suggest you take a look at the README here as
well:

tools/patman/README

But for now (this current patchset) I suggest to manually edit the
patches.

Thanks,
Stefan


More information about the U-Boot mailing list