[U-Boot] [PATCH v3 12/13] i2c: mxc: Make 'no gpio pinctrl state' print as debug

Heiko Schocher hs at denx.de
Tue Dec 6 15:08:05 CET 2016


Hello Jagan,

Am 06.12.2016 um 00:00 schrieb Jagan Teki:
> From: Jagan Teki <jagan at amarulasolutions.com>
>
> Some I2C bus devicetree nodes, doesn't require to have
> gpio pinctrl so replace the dev_info to debug so the
> print never comes on the console and for bus that uses
> gpio pinctrl anyway have dev_err.
>
> Before:
> ------
> U-Boot> i2c dev 1
> Setting bus to 1
> i2c bus 1 at 0x21a4000, no gpio pinctrl state.
>
> After:
> ------
> U-Boot> i2c dev 1
> Setting bus to 1
>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Michael Trimarchi <michael at amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> ---
>   drivers/i2c/mxc_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
>
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index 03a5ce9..94d9027 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -775,7 +775,7 @@ static int mxc_i2c_probe(struct udevice *bus)
>   	 */
>   	ret = fdt_stringlist_search(fdt, node, "pinctrl-names", "gpio");
>   	if (ret < 0) {
> -		dev_info(dev, "i2c bus %d at 0x%2lx, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
> +		debug("i2c bus %d at 0x%2lx, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
>   	} else {
>   		ret = gpio_request_by_name_nodev(fdt, node, "scl-gpios",
>   						 0, &i2c_bus->scl_gpio,
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list