[U-Boot] [PATCH 2/6] mmc: complete the unfinished move of CONFIG_MMC

[Masahiro Yamada]

Hi Tom,


2016-12-06 22:03 GMT+09:00 Tom Rini <trini at konsulko.com>:

>
>> I tried your suggestion.
>> It is true that 625 touched defconfigs were decreased to 389,
>> but do you think this is a really good idea?
>>
>> Theoretically, nothing of MMC
>> is related to ARM, PowerPC, Sandbox.
>>
>> I think this is shortening defconfigs
>> for the purpose of shortening.
>
> Yes, it is for the purpose of shortening the configs.
>
>> BTW, do you know that
>> Kbuild subsystem is discussing a new keyword "imply" ?
>>
>> https://patchwork.kernel.org/patch/9422463/
>>
>>
>> I am thinking it, if accepted, will be a better solution than
>> such unrelated "depends on <ARCH>" or "depends on <SOC>".
>
> Adding "imply" could help here I think, yes.  The problem is that I want
> to make the defaults in Kconfig produce a reasonable defconfig rather
> than require each new defconfig to require a lot of information to
> produce a reasonable binary.  Looking at the imply examples I think that
> yes, we could probably get away with doing things like:
> arch/Kconfig:
> config ARM
>         bool "ARM Architecture"
>         ...
>         imply MMC
>         imply DISPLAY_BOARDINFO
>         imply DISPLAY_CPUINFO
>

Yes, this looks better.

For now, I will go with "default ARM || PPC || SANDBOX".
I will send v2.


Once the "imply" is merged in the kernel,
we can immediately sync with it.
Then, it would be easy to convert "default" to "imply".



Oh, I found a more crazy default.
The "imply" may be helpful for cleanups.

config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR
        bool "MMC raw mode: by sector"
        depends on SPL
        default y if ARCH_SUNXI || ARCH_DAVINCI || ARCH_UNIPHIER ||ARCH_MX6 || \
                     ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
                     ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || \
                     OMAP44XX || OMAP54XX || AM33XX || AM43XX
        help
          Use sector number for specifying U-Boot location on MMC/SD in
          raw mode.



-- 
Best Regards
Masahiro Yamada