[U-Boot] [PATCHv4 09/16] pci: layerscape: add pci driver based on DM

Simon Glass sjg at chromium.org
Wed Dec 7 04:48:06 CET 2016


On 6 December 2016 at 00:03, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote:
> From: Minghuan Lian <Minghuan.Lian at nxp.com>
>
> There are more than five kinds of Layerscape SoCs. unfortunately,
> PCIe controller of each SoC is a little bit different. In order
> to avoid too many macro definitions, the patch addes a new
> implementation of PCIe driver based on DM. PCIe dts node is
> used to describe the difference.
>
> Signed-off-by: Minghuan Lian <Minghuan.Lian at nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> ---
> V4:
>  - Separated fixup code to pcie_layerscape_fixup.c.
>  - Added a header file pcie_layerscape.h.
>  - Removed board-specified #if, and use the SVR to differentiate in run-time.
>  - Corrected the indent of #ifs.
>  - Added comments on some conditions and functions.
>
>  drivers/pci/Kconfig                 |   8 +
>  drivers/pci/Makefile                |   1 +
>  drivers/pci/pcie_layerscape.c       | 815 +++++++++++++++++++++++-------------
>  drivers/pci/pcie_layerscape.h       | 191 +++++++++
>  drivers/pci/pcie_layerscape_fixup.c | 354 ++++++++++++++++
>  5 files changed, 1079 insertions(+), 290 deletions(-)
>  create mode 100644 drivers/pci/pcie_layerscape.h
>  create mode 100644 drivers/pci/pcie_layerscape_fixup.c

Reviewed-by: Simon Glass <sjg at chromium.org>

Although I would suggest splitting this out into two patches - one
that moves the code and one that changes it. It's really not feasible
to reviewed it as is.

- Simon


More information about the U-Boot mailing list