[U-Boot] [PATCH 1/5] net: phy: Fix mask so that we can identify Marvell 88E1518

[Stefan Roese]

On 09.12.2016 11:40, Phil Edworthy wrote:
> The mask for the 88E1510 meant that the 88E1518 code would never be
> used.
>
> Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>
> ---
> Note: This has only been tested on a board that uses a Marvell 88E1512
> PHY, see subsequent patches.
> ---
>  drivers/net/phy/marvell.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 4eeb0f6..06029c0 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -553,7 +553,7 @@ static struct phy_driver M88E1149S_driver = {
>  static struct phy_driver M88E1510_driver = {
>  	.name = "Marvell 88E1510",
>  	.uid = 0x1410dd0,
> -	.mask = 0xffffff0,
> +	.mask = 0xfffffff,
>  	.features = PHY_GBIT_FEATURES,
>  	.config = &m88e1510_config,
>  	.startup = &m88e1011s_startup,
> @@ -563,7 +563,7 @@ static struct phy_driver M88E1510_driver = {
>  static struct phy_driver M88E1518_driver = {
>  	.name = "Marvell 88E1518",
>  	.uid = 0x1410dd1,
> -	.mask = 0xffffff0,
> +	.mask = 0xfffffff,
>  	.features = PHY_GBIT_FEATURES,
>  	.config = &m88e1518_config,
>  	.startup = &m88e1011s_startup,

Nice catch, thanks. I wonder, why this wasn't detected until now. Still:

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan