[U-Boot] [U-boot] [bug report] After update from "2016.01" to "2016.09.01" display is shifted vertically - atmel lcd fb

[Robert Grzyb]

Current version of "drivers\video\atmel_lcdfb.c" seem to contain a
typo in the "lcd_ctrl_init" function:


diff -Naur u-boot-2016.09.01.orig/drivers/video/atmel_lcdfb.c
u-boot-2016.09.01/drivers/video/atmel_lcdfb.c
--- u-boot-2016.09.01.orig/drivers/video/atmel_lcdfb.c    2016-09-19
16:45:12.000000000 +0100
+++ u-boot-2016.09.01/drivers/video/atmel_lcdfb.c    2016-12-13
16:49:29.966346400 +0000
@@ -228,9 +228,9 @@
     timing.hsync_len.typ = panel_info.vl_hsync_len;

     timing.vactive.typ = panel_info.vl_row;
-    timing.vfront_porch.typ = panel_info.vl_clk;
-    timing.vback_porch.typ = panel_info.vl_clk;
-    timing.vsync_len.typ = panel_info.vl_clk;
+    timing.vfront_porch.typ = panel_info.vl_lower_margin;
+    timing.vback_porch.typ = panel_info.vl_upper_margin;
+    timing.vsync_len.typ = panel_info.vl_vsync_len;

     atmel_fb_init(panel_info.mmio, &timing, panel_info.vl_bpix,
               panel_info.vl_tft, panel_info.vl_cont_pol_low,



This change was introduced by this commit:
http://git.denx.de/?p=u-boot.git;a=commit;h=d63ec26a49a1ae8c0fd65c24e8c0b6c67b79cd01
referenced in this thread:
"[U-Boot] [PATCH 15/18] at91: video: Prepare for driver-model conversion"
http://lists.denx.de/pipermail/u-boot/2016-May/253489.html ""

In my case the display was shifted down by approximately 80 pixels but I presume
that this could have other effects depending on the value in 'panel_info.vl_clk'

Hope this helps someone,
Trebor.