[U-Boot] [PATCH 1/2] armv8: Enable CPUECTLR.SMPEN for coherency

Tom Rini trini at konsulko.com
Thu Dec 15 18:25:00 CET 2016


On Thu, Dec 15, 2016 at 05:22:38PM +0000, york sun wrote:
> On 12/15/2016 09:17 AM, Tom Rini wrote:
> > On Thu, Dec 15, 2016 at 04:55:44PM +0000, york sun wrote:
> >>
> >> Would it be a good idea to detect the core and apply this setting at run
> >> time, instead of using Kconfig option? Check the macro
> >> branch_if_a53_core, branch_if_a57_core for example.
> >>
> >
> > I think we need to look back at the discussion from the last time we
> > made a change around here, and make sure to fully understand what
> > platforms do and do not need / want to touch that.  See
> > d73718f3236c520a92efa401084c658e6cc067f3 and then
> > 3a592a1349ac3961b0f4f2db0a8d9f128225d897.
> >
> 
> Tom,
> 
> Thanks for the reminder. Yes we need to understand which platform really 
> needs this change. The author suggested using Kconfig option. It can 
> surely avoid applying this change blindly.

Yes.  I think this series as-is will be safe in that it's only being
enabled on NXP platforms that have (I will assume) all been tested with
the change.  But even for this series I want to make sure it's clear
when/why it would be needed and the Kconfig help should reflect that
information.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161215/d5e0f61a/attachment.sig>


More information about the U-Boot mailing list