[U-Boot] [PATCH v2 03/23] armv8: add lowlevel_init.S

[Simon Glass]

Hi Andre,

On 16 December 2016 at 19:55, André Przywara <andre.przywara at arm.com> wrote:
>
> On 05/12/16 06:26, Simon Glass wrote:
> > Hi Andre,
> >
> > On 4 December 2016 at 18:52, Andre Przywara <andre.przywara at arm.com> wrote:
> >> For boards that call s_init() when the SPL runs, we are expected to
> >> setup an early stack before calling this C function.
> >> Implement the proper AArch64 version of this based on the ARMv7 code.
> >> This allows sunxi boards to setup the basic peripherals even on with a
> >> 64-bit SPL.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> >> ---
> >>  arch/arm/cpu/armv8/Makefile        |  1 +
> >>  arch/arm/cpu/armv8/lowlevel_init.S | 44 ++++++++++++++++++++++++++++++++++++++
> >>  2 files changed, 45 insertions(+)
> >>  create mode 100644 arch/arm/cpu/armv8/lowlevel_init.S
> >
> > Is this actually needed / used for anything?
>
> All sunxi boards need to call s_init() in mach-sunxi/board.c.
> But I gave this a closer look:
> Indeed I believe we don't need lowlevel_init.S and the early call to
> s_init(). We can just follow the recommendation in lowlevel_init.S and
> move that code to board_init_f().
> I have a small series that reworks this, but this would affect all sunxi
> boards so should be considered separately.
>
> Are you OK if we go ahead with this solution here for now, as it creates
> the least churn?

Sounds good to me.

Regards,
Simon