[U-Boot] [PATCH v2 1/5] arm: tegra: initial support for apalis tk1

[Tom Warren]

Marcel,

> -----Original Message-----
> From: Marcel Ziswiler [mailto:marcel at ziswiler.com]
> Sent: Monday, December 19, 2016 7:36 AM
> To: u-boot at lists.denx.de
> Cc: Max Krummenacher <max.krummenacher at toradex.com>; Stefan Agner
> <stefan.agner at toradex.com>; Marcel Ziswiler
> <marcel.ziswiler at toradex.com>; Heiko Schocher <hs at denx.de>; Simon Glass
> <sjg at chromium.org>; Masahiro Yamada <yamada.masahiro at socionext.com>;
> York Sun <york.sun at nxp.com>; Tom Warren <TWarren at nvidia.com>; Lokesh
> Vutla <lokeshvutla at ti.com>; Ian Campbell <ijc at hellion.org.uk>; Peter Chubb
> <Peter.Chubb at data61.csiro.au>; Jaehoon Chung <jh80.chung at samsung.com>;
> Hans de Goede <hdegoede at redhat.com>; Alexander Graf <agraf at suse.de>;
> Albert Aribaud <albert.u.boot at aribaud.net>; Stefan Roese <sr at denx.de>;
> Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Stephen Warren
> <swarren at nvidia.com>
> Subject: [PATCH v2 1/5] arm: tegra: initial support for apalis tk1
> 
> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> 
> This patch adds board support for the Toradex Apalis TK1 a computer on
> module which can be used on different carrier boards.
> 
> The module consists of a Tegra TK1 SoC, a PMIC solution, 2 GB of DDR3L
> RAM, a bunch of level shifters, an eMMC, a TMP451 temperature sensor
> chip, an I210 gigabit Ethernet controller and a SGTL5000 audio codec.
> Furthermore, there is a Kinetis MK20DN512 companion micro controller for
> analogue, CAN and resistive touch functionality.
> 
> For the sake of ease of use we do not distinguish between different
> carrier boards for now as the base module features are deemed
> sufficient enough for regular booting.
> 
> The following functionality is working so far:
> - eMMC boot, environment storage and Toradex factory config block
> - Gigabit Ethernet
> - MMC/SD cards (both MMC1 as well as SD1 slot)
> - USB client/host (dual role OTG port as client e.g. for DFU/UMS or host,
>   other two ports as host)
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> ---
> 
> Changes in v2:
> - Added Simon's reviewed-by.
> 
>  arch/arm/dts/Makefile                              |    1 +
>  arch/arm/dts/tegra124-apalis.dts                   | 2203 ++++++++++++++++++++
>  arch/arm/mach-tegra/tegra124/Kconfig               |    7 +
>  board/toradex/apalis-tk1/Kconfig                   |   30 +
>  board/toradex/apalis-tk1/MAINTAINERS               |    7 +
>  board/toradex/apalis-tk1/Makefile                  |    5 +
>  board/toradex/apalis-tk1/apalis-tk1.c              |  175 ++
>  board/toradex/apalis-tk1/as3722_init.c             |  117 ++
>  board/toradex/apalis-tk1/as3722_init.h             |   41 +
>  .../toradex/apalis-tk1/pinmux-config-apalis-tk1.h  |  287 +++
>  configs/apalis-tk1_defconfig                       |   53 +
>  include/configs/apalis-tk1.h                       |  181 ++
>  12 files changed, 3107 insertions(+)
>  create mode 100644 arch/arm/dts/tegra124-apalis.dts
>  create mode 100644 board/toradex/apalis-tk1/Kconfig
>  create mode 100644 board/toradex/apalis-tk1/MAINTAINERS
>  create mode 100644 board/toradex/apalis-tk1/Makefile
>  create mode 100644 board/toradex/apalis-tk1/apalis-tk1.c
>  create mode 100644 board/toradex/apalis-tk1/as3722_init.c
>  create mode 100644 board/toradex/apalis-tk1/as3722_init.h
>  create mode 100644 board/toradex/apalis-tk1/pinmux-config-apalis-tk1.h
>  create mode 100644 configs/apalis-tk1_defconfig
>  create mode 100644 include/configs/apalis-tk1.h
> 
<snip>


I tried to apply this to u-boot-tegra/master (after rebasing that with u-boot/master TOT), and get the following build error:

board/toradex/apalis-tk1/apalis-tk1.c: In function 'ft_board_setup':
board/toradex/apalis-tk1/apalis-tk1.c:39:2: warning: implicit declaration of function 'ft_common_board_setup' [-Wimplicit-function-declaration]
board/toradex/common/built-in.o: In function `ft_board_setup':
/home/tom/denx/uboot-tegra/board/toradex/common/tdx-common.c:125: multiple definition of `ft_board_setup'
board/toradex/apalis-tk1/built-in.o:/home/tom/denx/uboot-tegra/board/toradex/apalis-tk1/apalis-tk1.c:39: first defined here
board/toradex/apalis-tk1/built-in.o: In function `ft_board_setup':
apalis-tk1.c:(.text.ft_board_setup+0x0): undefined reference to `ft_common_board_setup'
arm-none-linux-gnueabi-ld: BFD (Sourcery CodeBench Lite 2011.09-70) 2.21.53.20110905 assertion fail /scratch/jwlemke/2011.09-arm-linux-eabi-lite/obj/binutils-src-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu/bfd/elf32-arm.c:7504
arm-none-linux-gnueabi-ld: BFD (Sourcery CodeBench Lite 2011.09-70) 2.21.53.20110905 assertion fail /scratch/jwlemke/2011.09-arm-linux-eabi-lite/obj/binutils-src-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu/bfd/elf32-arm.c:13826
Segmentation fault (core dumped)
make: *** [u-boot] Error 139

Is this building OK for you against u-boot-tegra/master or u-boot/master?

Here are my top dozen commits for my local tegra/master (not yet pushed to Denx):

01646c4 colibri_t20: fix ulpi reset polarity
c68566a apalis_t30: comment about disabled pcie nodes
65b8f48 pci: kconfig: fix spelling in description
a4718e0 video: tegra: fix spelling in comment
6da200e apalis-tk1: disable external clock loopback on SDMMC3
a7bc3cf mmc: tegra: allow disabling external clock loopback
ee2289d mmc: tegra: move CONFIG_TEGRA_MMC from headers to defconfigs
69bdc09 mmc: tegra: introduce CONFIG_TEGRA_MMC to Kconfig
242af81 arm: tegra: initial support for apalis tk1
4fcb6d4 ARM: tegra: allow passing cboot DTB to the kernel
0b4bc1b Merge branch 'master' of git://git.denx.de/u-boot-spi
b5178a1 Merge git://git.denx.de/u-boot-fsl-qoriq

Thanks,

Tom
--
nvpublic