[U-Boot] rsa_verify calls fdt_next_node with a node offset from different device tree blob

Che-Liang Chiou clchiou at gmail.com
Fri Dec 23 22:09:06 CET 2016


Hi Simon,

I notice one thing that I am curious about. At v2016.11, in
lib/rsa/rsa-verify.c:rsa_verify function:

* The sig_node offset is computed from fdt_blob (at line 180):
sig_node = fdt_subnode_offset(blob, 0, FIT_SIG_NODENAME);

* At the end of the rsa_verify function, sig_node is applied to
info->fit to compute next offset (at line 210):
noffset = fdt_next_node(info->fit, sig_node, &ndepth);

blob (which is an alias of info->fdt_blob) and info->fit are two
different device tree blobs. And we probably should not call
fdt_next_node with offset from a different blob? (I'm not so sure
about fdt_next_node.)

Regards,
Che-Liang


More information about the U-Boot mailing list