[U-Boot] [PATCH 17/18] imx: imx7ulp: add EVK board support

[Fabio Estevam]

On Mon, Dec 26, 2016 at 5:00 AM, Peng Fan <peng.fan at nxp.com> wrote:
> Add EVK board support.
> Add the evk dts file.
>
> LOG:
> U-Boot 2017.01-rc2-00050-gdc633d6 (Dec 26 2016 - 10:34:05 +0800)
>
> CPU:   Freescale i.MX7ULP rev1.0 at 500 MHz
> Reset cause: POR-6

What does "POR-6" mean?

> Boot mode: Dual boot
> Model: NXP i.MX7ULP EVK
> Board: i.MX7ULP EVK board

Model and Board fields seem redundant here.

>  arch/arm/cpu/armv7/mx7ulp/Kconfig       |  11 +
>  arch/arm/dts/Makefile                   |   2 +
>  arch/arm/dts/imx7ulp-evk.dts            | 426 ++++++++++++++++++++++++++++++++
>  arch/arm/dts/imx7ulp-uboot.dtsi         |  43 ++++
>  board/freescale/mx7ulp_evk/Kconfig      |  12 +
>  board/freescale/mx7ulp_evk/Makefile     |  10 +
>  board/freescale/mx7ulp_evk/imximage.cfg | 131 ++++++++++
>  board/freescale/mx7ulp_evk/mx7ulp_evk.c |  77 ++++++
>  configs/mx7ulp_evk_defconfig            |  17 ++
>  include/configs/mx7ulp_evk.h            | 113 +++++++++

Missing MAINTAINERS file.

A README file would also be nice to have.

> +config TARGET_MX7ULP_EVK
> +        bool "Support mx7ulp EVK board"

MX7ULP

> +static int mx7ulp_board_rev(void)
> +{
> +       return 0x41;
> +}

What does hardcoded number mean?

> +int board_late_init(void)
> +{
> +#ifdef CONFIG_ENV_IS_IN_MMC
> +#if 0

No if 0 in the code, please.