[U-Boot] [PATCH V2 20/20] imx: mx7ulp_evk: enable mmc/regulator support

[Peng Fan]

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Fabio
> Estevam
> Sent: Tuesday, December 27, 2016 7:23 PM
> To: Peng Fan <peng.fan at nxp.com>
> Cc: U-Boot-Denx <u-boot at lists.denx.de>
> Subject: Re: [U-Boot] [PATCH V2 20/20] imx: mx7ulp_evk: enable
> mmc/regulator support
> 
> On Tue, Dec 27, 2016 at 8:04 AM, Peng Fan <peng.fan at nxp.com> wrote:
> 
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > +       "script=boot.scr\0" \
> > +       "image=zImage\0" \
> > +       "console=ttyLP0\0" \
> > +       "fdt_high=0xffffffff\0" \
> > +       "initrd_high=0xffffffff\0" \
> > +       "fdt_file=imx7ulp-evk.dtb\0" \
> > +       "fdt_addr=0x63000000\0" \
> > +       "boot_fdt=try\0" \
> 
> On this platform we will always boot from dt, so we can remove this variable...


Fix in v3.

> 
> > +       "earlycon=lpuart32,0x402D0010\0" \
> > +       "ip_dyn=yes\0" \
> > +       "mmcdev="__stringify(CONFIG_SYS_MMC_ENV_DEV)"\0" \
> > +       "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
> > +       "mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
> > +       "mmcautodetect=yes\0" \
> > +       "mmcargs=setenv bootargs console=${console},${baudrate} " \
> > +               "root=${mmcroot}\0" \
> > +       "loadbootscript=" \
> > +               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> > +       "bootscript=echo Running bootscript from mmc ...; " \
> > +               "source\0" \
> > +       "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
> ${image}\0" \
> > +       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0"
> \
> > +       "mmcboot=echo Booting from mmc ...; " \
> > +               "run mmcargs; " \
> > +               "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
> 
> ,which will also simplify things here.

Agree.

Thanks,
Peng.

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot